Update forwarding.rst #18092
Merged
Update forwarding.rst #18092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Mar 20, 2023
controller/forwarding.rst
Outdated
| @@ -13,8 +13,10 @@ Instead of redirecting the user's browser, this makes an "internal" sub-request | |||
| and calls the defined controller. The ``forward()`` method returns the | |||
| :class:`Symfony\\Component\\HttpFoundation\\Response` object that is returned | |||
| from *that* controller:: | |||
|
|
|||
| // src/Controller/OneController.php | |||
There was a problem hiding this comment.
No need for the path here
OskarStark
reviewed
Mar 20, 2023
controller/forwarding.rst
Outdated
| @@ -29,7 +31,9 @@ from *that* controller:: | |||
| The array passed to the method becomes the arguments for the resulting controller. | |||
| The target controller method might look something like this:: | |||
|
|
|||
| public function fancy($name, $color) | |||
| // src/Controller/OtherController.php | |||
There was a problem hiding this comment.
No need for the path here
|
@OskarStark i've reverted adding the path, even if at first it was the main topic of the PR :) |
OskarStark
approved these changes
Mar 20, 2023
|
Thank you @94noni. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some code clean, (and add comment to which file we are talking of)