Skip to content

[Console] Update style.rst #18085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023
Merged

[Console] Update style.rst #18085

merged 1 commit into from
Mar 20, 2023

Conversation

lougaou
Copy link
Contributor

@lougaou lougaou commented Mar 19, 2023

"ask" signature expects a string as second parameter

public function ask(string $question, string $default = null, callable $validator = null): mixed

Copy link
Contributor

@mdoutreluingne mdoutreluingne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
(note for the mergers: this can be merged in 5.4)

@javiereguiluz javiereguiluz added this to the 5.4 milestone Mar 20, 2023
@carsonbot carsonbot changed the title Update style.rst [Console] Update style.rst Mar 20, 2023
@javiereguiluz
Copy link
Member

Good catch Xavier! Thanks ... and congrats on your first Symfony Docs contribution 🎉

"ask" signature expects a string as second parameter

public function ask(string $question, string $default = null, callable $validator = null): mixed
@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 March 20, 2023 12:39
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner March 20, 2023 12:39
@javiereguiluz javiereguiluz merged commit bef1e59 into symfony:5.4 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants