Skip to content

[Serializer] Update reference to location of priorities of default normalizers #17992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

ArrMeeR
Copy link
Contributor

@ArrMeeR ArrMeeR commented Mar 2, 2023

No description provided.

Update documentation to reference correct priorities of default normalizers location
@carsonbot carsonbot added this to the 5.4 milestone Mar 2, 2023
@carsonbot carsonbot changed the title Update reference to location of priorities of default normalizers [Serializer] Update reference to location of priorities of default normalizers Mar 2, 2023
@javiereguiluz javiereguiluz merged commit 0c9cc8d into symfony:5.4 Mar 2, 2023
@javiereguiluz
Copy link
Member

@ArrMeeR thanks a lot for fixing this and congrats on your first Symfony Docs contribution 🎉

However, while merging this, we had to change your proposed solution 😐 The reason is that it was linking to the master version of symfony/symfony repo, which is no longer maintained. Also, linking to a specific file is always problematic because we need to change the version on each branch (5.4 docs should link to 5.4 code, 6.2 docs should link to 6.2 code, etc.)

That's why we opted to display instead the command console that you can run to get all these priorities. See 3c3a6b4

@ArrMeeR ArrMeeR deleted the patch-1 branch March 2, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants