Skip to content

[Logger] Add placeholders for dynamic data #17977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

alanpoulain
Copy link
Contributor

From @Crell's post:

Symfony's docs team can include a better example that includes a placeholder on the logging page. It doesn't have to be long, just one more example at the top showing how the placeholder works.

So here it is 😄

@carsonbot carsonbot added this to the 5.4 milestone Feb 27, 2023
@alanpoulain alanpoulain changed the title docs(logging): add placeholders for dynamic data [Logging] Add placeholders for dynamic data Feb 27, 2023
@alanpoulain alanpoulain changed the title [Logging] Add placeholders for dynamic data [Logger] Add placeholders for dynamic data Feb 27, 2023
@alanpoulain alanpoulain force-pushed the docs/logging-placeholders branch from 500d7dd to ccdcaad Compare February 27, 2023 19:24
@alanpoulain alanpoulain force-pushed the docs/logging-placeholders branch from ccdcaad to fcc67c9 Compare February 28, 2023 08:34
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool cool, thanks!

@carsonbot carsonbot changed the title [Logger] Add placeholders for dynamic data Add placeholders for dynamic data Feb 28, 2023
@carsonbot carsonbot changed the title Add placeholders for dynamic data [Logger] Add placeholders for dynamic data Feb 28, 2023
@javiereguiluz javiereguiluz merged commit 73f1eb4 into symfony:5.4 Feb 28, 2023
@javiereguiluz
Copy link
Member

Alan, thanks for this important contribution! And thanks to reviewers too.

Please note that while merging we reworded this a bit (1c33f40). The issue was that the whole explanation about placeholders was too long for a code comment.

So, we split it in two parts:

  • Short code comment explaining what are placeholders and how to add them
  • A proper text explanation below highlighting the main reasons why it's recommended to use placeholders

Thanks!

@alanpoulain
Copy link
Contributor Author

No problem, it's even clearer this way, thank you Javier.

@Crell
Copy link

Crell commented Mar 1, 2023

Excellent! Thank you everyone. I will update my blog post accordingly. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants