-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Form] Removed jQuery in favour of vanilla Javascript #17962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on this.
Let's ask others, like @ThomasLandauer and @weaverryan who talked recently about something similar related to some UX JS examples. Thanks
Ryan and me were discussing about another page in #17364, namely https://symfony.com/doc/current/form/form_collections.html#allowing-new-tags-with-the-prototype I wasn't even aware that this JavaScript code exists on https://symfony.com/doc/current/reference/forms/types/collection.html as well ;-) So given the fact that it's hard enough to maintain this entire collections/JavaScript topic in one place, I think those two pages/parts should be merged. Besides that, I agree that getting rid of jQuery is a good idea :-) |
Oh geez, same for me. Let's merge - I would make https://symfony.com/doc/current/form/form_collections.html#allowing-new-tags-with-the-prototype the source of truth and link from the reference, but either is fine. |
The easiest move and the one that make sense, is to remove the subsection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!
Jérôme, thanks for taking care of updating these docs and for your patience during the review process (and thanks to reviewers too). This is now merged, so congrats on your first Symfony Docs contribution 🎉 |
I don't see any value to use jQuery in the
forms types collection
documentation.If I'm missing a point let me know, otherwise we can work on this PR to remove it ?