Skip to content

[Form] Removed jQuery in favour of vanilla Javascript #17962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023
Merged

[Form] Removed jQuery in favour of vanilla Javascript #17962

merged 1 commit into from
Mar 1, 2023

Conversation

jeromegxj
Copy link
Contributor

I don't see any value to use jQuery in the forms types collection documentation.
If I'm missing a point let me know, otherwise we can work on this PR to remove it ?

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on this.

Let's ask others, like @ThomasLandauer and @weaverryan who talked recently about something similar related to some UX JS examples. Thanks

@ThomasLandauer
Copy link
Contributor

Ryan and me were discussing about another page in #17364, namely https://symfony.com/doc/current/form/form_collections.html#allowing-new-tags-with-the-prototype

I wasn't even aware that this JavaScript code exists on https://symfony.com/doc/current/reference/forms/types/collection.html as well ;-) So given the fact that it's hard enough to maintain this entire collections/JavaScript topic in one place, I think those two pages/parts should be merged.
If you agree with that in principle, the question would be: Which one should contain everything, and which one mainly a link to the other?

Besides that, I agree that getting rid of jQuery is a good idea :-)

@weaverryan
Copy link
Member

I wasn't even aware that this JavaScript code exists on https://symfony.com/doc/current/reference/forms/types/collection.html as well ;-) So given the fact that it's hard enough to maintain this entire collections/JavaScript topic in one place, I think those two pages/parts should be merge

Oh geez, same for me. Let's merge - I would make https://symfony.com/doc/current/form/form_collections.html#allowing-new-tags-with-the-prototype the source of truth and link from the reference, but either is fine.

@jeromegxj
Copy link
Contributor Author

jeromegxj commented Feb 27, 2023

The easiest move and the one that make sense, is to remove the subsection collection.html#adding-and-removing-items
That page already has multiple links to https://symfony.com/doc/current/form/form_collections.html#allowing-new-tags-with-the-prototype

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@carsonbot carsonbot changed the title Removed jQuery in favour of vanilla Javascript [Form] Removed jQuery in favour of vanilla Javascript Mar 1, 2023
@javiereguiluz javiereguiluz added this to the 5.4 milestone Mar 1, 2023
@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 March 1, 2023 15:43
@javiereguiluz
Copy link
Member

Jérôme, thanks for taking care of updating these docs and for your patience during the review process (and thanks to reviewers too). This is now merged, so congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 3e76637 into symfony:5.4 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants