[Mailer] Switching to new config format #17934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Feb 21, 2023
|
Is this change really necessary? Aren't DSN already strings? |
|
The important part is the lower part of the PR: Switching from the old array syntax to the newer Configurator syntax. |
|
The string stuff can be removed 👍 |
|
Well, I thought that casting it to a string (just to make sure) would be a good idea. Don't you think? |
|
I don't think so. If I don't miss anything, we don't do that anywhere else. |
|
OK, there you go :-) |
|
Merged! Sorry it took us so long. Thanks Thomas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page: https://symfony.com/doc/5.4/mailer.html