[Notifier] Add link to readme bridges #17902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
Feb 13, 2023
OskarStark
reviewed
Feb 14, 2023
alamirault
force-pushed
the
feature/notifier-link-to-readme
branch
from
7ec3c95 to
936f9a7
Compare
|
Needs merge and release of |
javiereguiluz
added a commit
to symfony-tools/docs-builder
that referenced
this pull request
Mar 23, 2023
This PR was squashed before being merged into the main branch.
Discussion
----------
Replace `{version}` in URLs
In order to make link on symfony codebase, even if is not a class or a method reference
Can be usefull in this case for example symfony/symfony-docs#17902
Commits
-------
3d54708 Replace `{version}` in URLs
OskarStark
reviewed
Mar 23, 2023
OskarStark
reviewed
Mar 23, 2023
|
Can you please do the same for "Chat Channel" ? Thanks |
alamirault
force-pushed
the
feature/notifier-link-to-readme
branch
from
4b2e6e7 to
92e1bd9
Compare
alamirault
commented
Mar 23, 2023
alamirault
force-pushed
the
feature/notifier-link-to-readme
branch
from
92e1bd9 to
0f2412e
Compare
|
@OskarStark Done ! I think we have nothing to do for bridges which have specific documentation page. I can provide PR on 6.x branches if it can help for upmerge |
|
Not now, but @MrYamous can change them accordingly after |
OskarStark
approved these changes
Mar 24, 2023
fabpot
approved these changes
Mar 25, 2023
fabpot
force-pushed
the
feature/notifier-link-to-readme
branch
from
97e33b0 to
a58ad94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here #17289 (comment), notifier options should be documented directly in bridge README.
I think github icon on left of brigde name/link it enough for visibility.
I made it only
SMS Channelbut it must also be done onChat ChannelCan fix #17289 #16546