Switching to PHP-version-agnostic socket file #17890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page: https://symfony.com/doc/5.4/setup/web_server_configuration.html This makes upgrading to a new PHP version so much easier (I just did that). If the PHP version is hardcoded in every domain's config file, it's a hassle to update them. On the other hand: `/var/run/php/php-fpm.sock` is a symlink to the most recently installed PHP version, so this is what most people want probably. I hope this doesn't interfere with the change I did in symfony#17882 on the 6.2 branch.
OskarStark
approved these changes
Feb 10, 2023
|
Thank you Thomas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page: https://symfony.com/doc/5.4/setup/web_server_configuration.html
This makes upgrading to a new PHP version so much easier (I just did that). If the PHP version is hardcoded in every domain's config file, it's a hassle to update them.
On the other hand:
/var/run/php/php-fpm.sockis a symlink to the most recently installed PHP version, so this is what most people want probably.I hope this doesn't interfere with the change I did in #17882 on the 6.2 branch.