Skip to content

[BrowserKit][HttpClient] Add examples to set cookies in the request #17888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexandre-daubois
Copy link
Member

Fixes #17875

@carsonbot carsonbot added this to the 5.4 milestone Feb 10, 2023
@carsonbot carsonbot changed the title [HttpClient][BrowserKit] Add examples to set cookies in the request [BrowserKit][HttpClient] Add examples to set cookies in the request Feb 10, 2023
http_client.rst Outdated
Comment on lines 701 to 704
.. note::

The :class:`Symfony\\Component\\HttpFoundation\\Cookie` class is a helper to
help you create cookies. You're also able to pass a simple string as the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of the note, lets do something like this instead? (see above)

@alexandre-daubois alexandre-daubois force-pushed the cookies-header-httpclient-browserkit branch from 9daacae to 0f6b353 Compare February 10, 2023 12:20
@javiereguiluz javiereguiluz merged commit 675ad18 into symfony:5.4 Feb 10, 2023
@javiereguiluz
Copy link
Member

Nice contribution as always. Thanks Alex!

@alexandre-daubois alexandre-daubois deleted the cookies-header-httpclient-browserkit branch February 10, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants