Skip to content

[HttpClient] Allow yielding Exception from MockResponse's $body to mock transport errors #17823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandre-daubois
Copy link
Member

Fixes #16306

@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.2, 6.3.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 6.1 milestone Jan 29, 2023
@javiereguiluz javiereguiluz changed the base branch from 6.1 to 6.2 February 8, 2023 16:30
@javiereguiluz javiereguiluz force-pushed the yield-exception-mock-response branch from a08fc27 to e6be0eb Compare February 8, 2023 16:31
@javiereguiluz javiereguiluz merged commit 46fb1b7 into symfony:6.2 Feb 8, 2023
@javiereguiluz
Copy link
Member

A cool feature ... and a very nice and easy to understand explanation. Thanks Alex!

@alexandre-daubois alexandre-daubois deleted the yield-exception-mock-response branch February 8, 2023 17:06
@alexandre-daubois
Copy link
Member Author

My pleasure @javiereguiluz 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HttpClient] Allow yielding Exception from MockResponse's $body to moc…
3 participants