Update "Web debug toolbar" profiler docs #17809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
commented
Jan 25, 2023
florimondmanca
force-pushed
the
patch-1
branch
2 times, most recently
from
bc44772 to
d233a68
Compare
Update profiler.rst
florimondmanca
force-pushed
the
patch-1
branch
from
d233a68 to
e8cc35d
Compare
|
@florimondmanca sorry it took us so long to merge this. Thanks a lot for fixing this issue ... and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I believe I encountered the situation than symfony/symfony#42439
The current docs on updating the Web debug toolbar after XHR requests suggest to use
$event->getKernel()->isDebug().I am using Symfony 6.2, and this results in an attribute error on
isDebug(). This seems to be becausegetKernel()returns an object that implementsHttpKernelInterface, which does not defineisDebug(). However, this method is available onKernelInterace.I was able to get the intended behavior by injecting the kernel via the constructor, as shown in this documentation update proposal.
I checked as follows:
APP_ENV=dev. The toolbar shows up and I can seeSymfony-Debug-Toolbar-Replace: 1in the XHR requests (I'm using Turbo Frames)APP_ENV=prod. The toolbar doesn't show up, and I cannot seeSymfony-Debug-Toolbar-Replace: 1in the XHR requests anymore.I am targeting
5.4as the base branch as per the contribution guidelines, given that it should be possible to inject theKernelInterfacein Symfony 5.4 as well.