[Validator] Mention exactly option for Length constraint
#17764
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
approved these changes
Jan 17, 2023
OskarStark
reviewed
Jan 18, 2023
OskarStark
reviewed
Jan 18, 2023
Comment on lines
+177
to
+178
| without passing any named argument to it. This means that for example, | ||
| ``@Assert\Length(20)`` and ``@Assert\Length(exactly=20)`` are equivalent, as |
There was a problem hiding this comment.
We can remove the annotation part in a follow up PR against 6.0
There was a problem hiding this comment.
I'll take care of this after the merge 👌
alexandre-daubois
force-pushed
the
exactly-lenght-constraint
branch
from
54caa90 to
99ac309
Compare
OskarStark
reviewed
Jan 18, 2023
reference/constraints/Length.rst
Outdated
| ``@Assert\Length(20)`` and ``@Assert\Length(exactly=20)`` are equivalent, as | ||
| well as ``#[Assert\Length(20)]`` and ``#[Assert\Length(exactly: 20)]``. | ||
|
|
||
| .. versionadded:: |
There was a problem hiding this comment.
Suggested change
| .. versionadded:: | |
| .. versionadded:: 5.2 |
There was a problem hiding this comment.
My bad 🤦 Thanks again!
|
Thank you Alexandre. |
alexandre-daubois
force-pushed
the
exactly-lenght-constraint
branch
from
99ac309 to
2c41c8b
Compare
|
I already merged and added the version in fd74bd6 |
OskarStark
added a commit
that referenced
this pull request
Jan 18, 2023
…Length constraint (alexandre-daubois) This PR was merged into the 6.0 branch. Discussion ---------- [Validator] Remove annotations from `exactly` option of Length constraint Follow-up #17764 (comment) Commits ------- 13d15fa [Validator] Remove annotations from `exactly` option of Length constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17059