[DependencyInjection] Complete examples with #[TaggedIterator] and #[TaggedLocator] attributes
#17747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
tagged-iterator-attribute-completion
branch
2 times, most recently
from
37bdbf3 to
e77747b
Compare
OskarStark
reviewed
Jan 15, 2023
| class CommandBus | ||
| { | ||
| public function __construct( | ||
| #[TaggedLocator('app.handler', indexAttribute: 'key')] ServiceLocator $locator |
There was a problem hiding this comment.
Suggested change
| #[TaggedLocator('app.handler', indexAttribute: 'key')] ServiceLocator $locator | |
| #[TaggedLocator('app.handler', indexAttribute: 'key')] | |
| ServiceLocator $locator |
Lets go with a line break here and in the other examples
There was a problem hiding this comment.
Agree! Here you go 👍
OskarStark
approved these changes
Jan 15, 2023
OskarStark
changed the title
#[TaggedIterator] and #[TaggedLocator] attributes
…dLocator attributes
alexandre-daubois
force-pushed
the
tagged-iterator-attribute-completion
branch
from
e77747b to
f6c140c
Compare
OskarStark
approved these changes
Jan 15, 2023
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15948