[ExpressionLanguage] Merge docs about ExpresssionLanguage #17724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
expression-language-docs-merge
branch
from
bb23a4a to
98abff5
Compare
javiereguiluz
added
Status: Reviewed
ExpressionLanguage
and removed
Status: Needs Review
labels
carsonbot
changed the title
javiereguiluz
force-pushed
the
expression-language-docs-merge
branch
from
98abff5 to
3ecb282
Compare
|
Thanks Fabien for another nice doc merging PR. |
wouterj
reviewed
Jan 12, 2023
| @@ -1,320 +0,0 @@ | |||
| .. index:: | |||
There was a problem hiding this comment.
I think we should keep th is article separate, as this is much more a reference article than a guide
There was a problem hiding this comment.
I'm not saying that you are wrong ... but in my opinion, having most of the things related to ExpressionLanguage in a single (long, but manageable) article is better for readers.
And with the recent doc redesign, the sticky TOC will make it easier to browse long articles and quickly move between sections.
There was a problem hiding this comment.
Yes, for the same type of documentation (and with emphasis on the managable).
But no for different types of documentation imho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.