Add a section about how to add an argument to a method without breaking BC #17706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
bc-break-workarounds
branch
4 times, most recently
from
84b7133 to
d187536
Compare
stof
reviewed
Jan 10, 2023
fabpot
force-pushed
the
bc-break-workarounds
branch
from
d187536 to
43f5a76
Compare
GromNaN
reviewed
Jan 10, 2023
| { | ||
| } | ||
|
|
||
| #. Document the new argument in a PHPDoc:: |
There was a problem hiding this comment.
We can mention this must be documented in all child classes.
stof
reviewed
Jan 10, 2023
Probably the next to document indeed. |
OskarStark
reviewed
Jan 10, 2023
javiereguiluz
force-pushed
the
bc-break-workarounds
branch
from
0422193 to
f068e3c
Compare
|
Thank you Fabien. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our section about BC breaks is too strict in the sense that we do have solutions for some of the things mentioned as not possible.
This PR documents one of them.