Skip to content

[DependencyInjection] Add exclude to TaggedIterator and TaggedLocator #17645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

[DependencyInjection] Add exclude to TaggedIterator and TaggedLocator #17645

merged 1 commit into from
Jan 4, 2023

Conversation

alexandre-daubois
Copy link
Member

Resolves #16339

@carsonbot carsonbot added this to the 6.1 milestone Jan 3, 2023
dbrumann
dbrumann reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from versioninfo, it looks good to me.

Thanks for adding this. 👍 I was just looking for this in the docs

service_container/tags.rst
;
};

.. versionadded:: 6.1
Copy link
Contributor

@dbrumann dbrumann Jan 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? symfony/symfony#47902 was merged into the 6.2 branch.

Nevermind, I just saw that the initial implementation was done in 6.1.

@javiereguiluz javiereguiluz merged commit 27d591d into symfony:6.1 Jan 4, 2023
@javiereguiluz
Copy link
Member

Thanks Alexandre!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrumann dbrumann dbrumann approved these changes

@alamirault alamirault alamirault approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandre-daubois @javiereguiluz @dbrumann @alamirault @carsonbot