Remove reference to 2.x, 3.x, 4.x versions #17589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
Dec 18, 2022
alamirault
commented
Dec 18, 2022
alamirault
commented
Dec 18, 2022
OskarStark
reviewed
Dec 18, 2022
OskarStark
reviewed
Dec 18, 2022
OskarStark
reviewed
Dec 18, 2022
OskarStark
approved these changes
Dec 20, 2022
xabbuh
approved these changes
Dec 21, 2022
|
looks good to me, I don't think we need redirects for the two removed chapters @javiereguiluz @wouterj What do you think? |
|
I agree with @xabbuh: we "soft removed" those two articles in 4.0 version, so we can now fully remove them. I'm merging this in 6.0 branch and up. Thanks Antoine for an excellent contribution! |
javiereguiluz
force-pushed
the
feature/remove-eol-references
branch
from
8b65c0c to
98a1dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17583