Skip to content

Adding deprecation information #17518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Adding deprecation information #17518

wants to merge 1 commit into from

Conversation

ThomasLandauer
Copy link
Contributor

No description provided.

94noni
94noni reviewed Dec 6, 2022
View reviewed changes
routing.rst
@@ -955,6 +955,10 @@ To add support for "param converters" we need SensioFrameworkExtraBundle:

$ composer require sensio/framework-extra-bundle

.. versionadded:: 6.2

SensioFrameworkExtraBundle was deprecated in Symfony 6.2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this true? I mean this is independent release, what bout instead of version added, mark a note or a caution that the bundle is now global inside symfony core as attributes ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/README.md
I don't know how the param converter works now. Just thought, adding a quick note is better than nothing :-)

@xabbuh
Copy link
Member

xabbuh commented Dec 7, 2022

What about removing the whole section instead?

@javiereguiluz
Copy link
Member

javiereguiluz commented Dec 8, 2022 •
edited
Loading

Instead of removing the section entirely, we could briefly mention what's this (because I think it's very relevant to routing) and then link to the docs about the new #[MapEntity] attribute

@wouterj
Copy link
Member

wouterj commented Dec 8, 2022

I agree with Javier. And we might want to add a very small deprecated notice along the lines of "Prior to Symfony 6.2, this feature was provided by the SensioFrameworkExtraBundle." or something like that. (I can imagine that you might be a bit lost if you don't follow Symfony closely and can't find anything about the SensioFrameworkExtraBundle in the docs anymore)

@javiereguiluz
Copy link
Member

I just saw that in another PR we have something like this but for another section. So, we could get inspiration from it: https://github.com/symfony/symfony-docs/pull/17530/files

@ThomasLandauer
Copy link
Contributor Author

Sorry, I don't know enough to do this :-(

@javiereguiluz javiereguiluz mentioned this pull request Mar 3, 2023
Merged
@javiereguiluz
Copy link
Member

Closing in favor of #17999.

@ThomasLandauer ThomasLandauer deleted the patch-22 branch March 3, 2023 20:28
OskarStark added a commit that referenced this pull request Mar 7, 2023
@OskarStark
minor #17999 [Routing] Mention that param converters are now native (…
43325d0 
…javiereguiluz)

This PR was merged into the 6.2 branch.

Discussion
----------

[Routing] Mention that param converters are now native

Replaces #17518

Commits
-------

aafff28 [Routing[ Mention that param converters are now native
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@94noni 94noni 94noni left review comments

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ThomasLandauer @xabbuh @javiereguiluz @wouterj @94noni @carsonbot