[DependencyInjection] Typo on how default defaultIndexMethod work #17342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Oct 12, 2022
OskarStark
reviewed
Oct 12, 2022
javiereguiluz
added
Status: Reviewed
DependencyInjection
and removed
Status: Needs Review
labels
carsonbot
changed the title
|
This has been finally merged! Thanks Bastien. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the documentation, I was trying the static method getDefaultIndexName() to have named tagged service and it didn't work. I looked at the code here in how I understand it, you have to declare the index_by attribute to be able to use the getDefault****Name() method.
I tryed to improve the documentation, but I think it could be better explained that what I did.
It is the same logique for the getDefault***Priority() method.