Skip to content

[Console] docs(console): add caution for testing option #17326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022
Merged

[Console] docs(console): add caution for testing option #17326

merged 1 commit into from
Oct 4, 2022

Conversation

jeremyhalin
Copy link
Contributor

Add a caution about InputOption::VALUE_NONE testing. Passing only a value without a key doesn't work and can lead to misunderstanding.

@carsonbot carsonbot changed the title docs(console): add caution for testing option [Console] docs(console): add caution for testing option Oct 4, 2022
@javiereguiluz javiereguiluz added this to the 5.4 milestone Oct 4, 2022
Add a caution about `InputOption::VALUE_NONE` testing.
Passing only a value without a key doesn't work and can lead to misunderstanding.
@javiereguiluz javiereguiluz changed the base branch from 6.1 to 5.4 October 4, 2022 15:47
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner October 4, 2022 15:47
@javiereguiluz javiereguiluz merged commit b54b7ee into symfony:5.4 Oct 4, 2022
@javiereguiluz
Copy link
Member

Thanks Jérémy ... and congrats on your first Symfony Docs contribution 🎉

@jeremyhalin jeremyhalin deleted the patch-1 branch October 5, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants