Skip to content

Adding an overview of how the service container concepts fit togther #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2012

Conversation

richardmiller-zz
Copy link
Contributor

Based on feedback from some people about how there s nothing to say how all the various parts of building the container fit together and nothing to say where the files should live.

together whether you are using the full stack framework or looking to use
the service container in another application.

The full stack framework uses the ``HTTPKernel`` component to manage the loading
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HttpKernel to match its naming. and this should be a link to the component doc, no ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof Thanks for you help with this, I have changed the errors you have pointed out. I can't link to the HttpKernel documentation yet though as it still needs writing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, it does not exist yet ? It could be a good choice for the next step as many external libraries are starting to build on it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on my list :)

weaverryan added a commit that referenced this pull request Oct 3, 2012
Adding an overview of how the service container concepts fit togther
@weaverryan weaverryan merged commit d67d44a into symfony:2.0 Oct 3, 2012
@weaverryan
Copy link
Member

Hey Richard!

Looks good - some proofreading and merged in.

Thanks!

@weaverryan
Copy link
Member

Btw, just saw an old comment you made about HttpKernel on a diff. I'm working on bootstrapping the HttpKernel component docs right now - but give me about a week and a half - I have a honeymoon to go on first :). But, I wanted to make sure we weren't duplicating effort.

@richardmiller-zz
Copy link
Contributor Author

I got as far as making some notes a few weeks ago but I have not had any time to make progress since then. I will leave it for now since you are already working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants