Skip to content

[Twig] Document the new methods of AppVariable #17275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2022
Merged

[Twig] Document the new methods of AppVariable #17275

merged 1 commit into from
Sep 17, 2022

Conversation

javiereguiluz
Copy link
Member

Fixes #17265.

@javiereguiluz javiereguiluz added this to the 6.2 milestone Sep 16, 2022
@carsonbot carsonbot changed the title [TwigBridge] Document the new methods of AppVariable [Twig] Document the new methods of AppVariable Sep 16, 2022
HeahDude
HeahDude suggested changes Sep 17, 2022
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to do that this morning, thanks!

Also I thought we could update the last block of this section: https://symfony.com/doc/current/routing.html#getting-the-route-name-and-parameters.

@javiereguiluz
Copy link
Member Author

Jules, thanks for the review and the fixes! (and thanks for implementing the feature too)

@javiereguiluz javiereguiluz merged commit d51cb79 into symfony:6.2 Sep 17, 2022
@javiereguiluz javiereguiluz deleted the fix_17265 branch September 17, 2022 08:31
xabbuh added a commit that referenced this pull request Sep 17, 2022
@xabbuh
[#17275] fix typo
3c35bf4
@xabbuh
Copy link
Member

xabbuh commented Sep 17, 2022

👍 I fixed a small typo in 3c35bf4

@HeahDude HeahDude mentioned this pull request Sep 17, 2022
Merged
javiereguiluz added a commit that referenced this pull request Sep 17, 2022
@javiereguiluz
minor #17279 [Routing] Improve current route block (HeahDude)
c242e1e 
This PR was merged into the 6.2 branch.

Discussion
----------

[Routing] Improve current route block

Continuation of #17275.

Commits
-------

8f9a5e0 [Routing] Improve current route block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude requested changes

Assignees
No one assigned
Labels
Status: Reviewed Twig TwigBridge
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

[TwigBridge] Expose current route in AppVariable
4 participants
@javiereguiluz @xabbuh @HeahDude @carsonbot