Skip to content

[Form] Fixing "HTML5 color format" link #17256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Conversation

ktherage
Copy link
Contributor

@ktherage ktherage commented Sep 8, 2022

@ktherage ktherage requested a review from xabbuh as a code owner September 8, 2022 14:22
@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.4, 6.0, 6.1, 6.2.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 5.1 milestone Sep 8, 2022
@javiereguiluz
Copy link
Member

javiereguiluz commented Sep 8, 2022

Thanks for this contribution! If possible, please check if this same error occurs in 5.4 branch, which is the oldest maintained branch that could contain the mistake, and try to rebase this pull request to that branch. Thanks!

ThomasLandauer and others added 2 commits September 13, 2022 09:41
All other code samples on this page are using `form/`
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] Fixing path

All other code samples on this page are using `form/`

Commits
-------

e6bdd5d Fixing path
@javiereguiluz javiereguiluz modified the milestones: 5.1, 5.4 Sep 14, 2022
@carsonbot carsonbot changed the title Fixing "HTML5 color format" link [Form] Fixing "HTML5 color format" link Sep 14, 2022
* 4.4:
  Fixing path
@javiereguiluz javiereguiluz changed the base branch from 5.1 to 5.4 September 14, 2022 14:56
@javiereguiluz
Copy link
Member

Merged in 5.4. Thanks!

@javiereguiluz javiereguiluz merged commit 2eee2d0 into symfony:5.4 Sep 14, 2022
@ktherage ktherage deleted the patch-2 branch September 22, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants