Deprecate not configuring explicitly a provider for custom_authenticators when there is more than one registered provider #17215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
xabbuh
reviewed
Oct 31, 2022
security/custom_authenticator.rst
Outdated
|
|
||
| Having multiple user providers and a ``custom_authenticator`` and not having specified the user provider | ||
| to use has been deprecated in Symfony 5.4. If you have registered multiple user providers, you must set the | ||
| ``provider`` key to one of the configured providers, even if your custom authenticators don't use it. |
There was a problem hiding this comment.
I think I would reword this a bit:
If you have registered multiple user providers, you must set the
providerkey to one of the configured providers, even if your custom authenticators don't use it. Not doing so is deprecated in Symfony 5.4.
There was a problem hiding this comment.
I agree, it's done
xabbuh
approved these changes
Nov 1, 2022
…tors when there is more than one registered provider
|
Thank you @mdoutreluingne. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16041