Skip to content

[DependecyInjection] Added Uses & hints #17197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

mohamedGasmii
Copy link
Contributor

No description provided.

@carsonbot carsonbot added this to the 5.4 milestone Aug 17, 2022
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 for the Response return type, but -1 for the uses and Route attribute. The // ... indicates that not all information is present in this example, and the example should stay focussed on what it is demonstrating: the dependency injection.

Also, I see a lot of PRs by you from the past days. It's nice to receive contributions, but many small PRs add a lot of maintenance overhead (reviewing, merging, etc). Please try to combine more changes in a single PR if they are about the same topic (e.g. "add return types to all code examples in the Cache chapter").

@mohamedGasmii
Copy link
Contributor Author

mohamedGasmii commented Aug 17, 2022

@wouterj Thank you for your feedback, i removed the uses & route attribute and i try to combine small changes for the next PRs.

@xabbuh xabbuh changed the base branch from 5.4 to 4.4 August 22, 2022 08:12
@xabbuh xabbuh requested a review from OskarStark as a code owner August 22, 2022 08:12
@xabbuh
Copy link
Member

xabbuh commented Aug 22, 2022

Thank you @mohamedGasmii.

@xabbuh xabbuh merged commit 5cc1339 into symfony:4.4 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants