[Mailer] add new events #17181
Merged
[Mailer] add new events #17181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Aug 15, 2022
mailer.rst
Outdated
|
|
||
| .. versionadded:: 6.2 | ||
|
|
||
| ``SentMessageEvent`` and ``FailedMessageEvent`` was introduced in Symfony 6.2. |
mailer.rst
Outdated
| SentMessageEvent | ||
| ~~~~~~~~~~~~ | ||
|
|
||
| ``SentMessageEvent`` it allows acting on the :class:`Symfony\\Component\\Mailer\\SentMessage`:: |
There was a problem hiding this comment.
Perhaps document like this?
https://symfony.com/doc/current/reference/events.html#kernel-request
When and why and what can be done in it
There was a problem hiding this comment.
Good idea !
Personally I like it when it's uniform (it's simpler and nicer to read). So I standardized like https://symfony.com/doc/current/reference/events.html#kernel-request
I have detailed this event. Thanks for your review
javiereguiluz
force-pushed
the
mailer/add-new-events
branch
from
12033eb to
5c545bd
Compare
|
Nice contribution! Thanks Maxime ... and thanks to reviewers too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17071