Skip to content

Shortening code block for PHP #17178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Shortening code block for PHP #17178

merged 1 commit into from
Aug 23, 2022

Conversation

ThomasLandauer
Copy link
Contributor

If you agree, I'll shorten YAML and XML too.

@carsonbot carsonbot added this to the 5.4 milestone Aug 14, 2022
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@xabbuh
Copy link
Member

xabbuh commented Aug 15, 2022

@symfony/team-symfony-docs What's your opinion here?

@wouterj
Copy link
Member

wouterj commented Aug 21, 2022

I agree, this looks much better to me :)

@xabbuh
Copy link
Member

xabbuh commented Aug 21, 2022

@ThomasLandauer Can you update the other formats as you suggested?

@ThomasLandauer
Copy link
Contributor Author

There you go :-)

@wouterj
Copy link
Member

wouterj commented Aug 23, 2022

Thanks @ThomasLandauer.

@wouterj wouterj merged commit 83912c6 into symfony:5.4 Aug 23, 2022
@ThomasLandauer ThomasLandauer deleted the patch-35 branch August 23, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants