Skip to content

Typo fix #17158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Typo fix #17158

merged 1 commit into from
Aug 15, 2022

Conversation

andyexeter
Copy link
Contributor

"Secret" should be plural "Secrets" in this context.

@alexislefebvre
Copy link
Contributor

This title exists in Symfony 4.4 https://symfony.com/doc/4.4/best_practices.html#use-secret-for-sensitive-information I think the PR should target 4.4.

@andyexeter andyexeter changed the base branch from 6.1 to 4.4 August 14, 2022 11:36
@andyexeter andyexeter changed the base branch from 4.4 to 6.1 August 14, 2022 11:37
@andyexeter
Copy link
Contributor Author

What's the best way of updating the PR to target 4.4? I tried to change the base via github but it brought across hundreds of other commits.

@alexislefebvre
Copy link
Contributor

@andyexeter

  • easiest method: close this PR, edit the file from the 4.4 branch and open a PR targeting 4.4
  • more complicated method: rebasing may be too much work, but you can checkout the 4.4 branch locally, cherry-pick your commit, then push force on the branch of this PR, and finally change the targeted branch in this PR

@OskarStark
Copy link
Contributor

OskarStark commented Aug 15, 2022

We can merge it against 4.4 no problem 😃

@xabbuh xabbuh added this to the 4.4 milestone Aug 15, 2022
@xabbuh xabbuh changed the base branch from 6.1 to 4.4 August 15, 2022 09:03
@xabbuh
Copy link
Member

xabbuh commented Aug 15, 2022

Thank you @andyexeter.

@xabbuh xabbuh merged commit d2725a0 into symfony:4.4 Aug 15, 2022
@andyexeter andyexeter deleted the patch-1 branch October 4, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants