[Config] Delete a page that it's no longer needed #17143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
javiereguiluz
changed the title
|
What about redirecting the users to the previous version if they click on a old link? Like this:
|
|
@alexislefebvre I didn't explain myself well. What you ask is the current behavior for "Not Found" pages. We list the Symfony versions for which that page existed before. See for example: https://symfony.com/doc/2.2/frontend.html |
|
@javiereguiluz thanks for the explanation, that's great. |
xabbuh
approved these changes
Aug 11, 2022
HeahDude
approved these changes
Aug 11, 2022
javiereguiluz
added a commit
that referenced
this pull request
Aug 11, 2022
…reguiluz) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Config] Delete a page that it's no longer needed Fixes #17133. Symfony 4.4, the oldest maintained Symfony version, was released on November 2019, so this page is no longer relevant. When we delete or move some doc page, we always provide an alternative to avoid errors. In this case, this page is so special that it doesn't really have an alternative. Redirecting to any other page would be wrong. So, let's delete the file and people visiting the page will see an error page showing that the page is only available for some past Symfony versions. Commits ------- 4150590 [Config] Delete a page that it's no longer needed
javiereguiluz
force-pushed
the
fix_17133
branch
from
36efa1e to
4150590
Compare
|
I double checked this just in case ... and the deleted page is correctly displaying the past versions where it was available: https://symfony.com/doc/current/configuration/dot-env-changes.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17133.
Symfony 4.4, the oldest maintained Symfony version, was released on November 2019, so this page is no longer relevant.
When we delete or move some doc page, we always provide an alternative to avoid errors. In this case, this page is so special that it doesn't really have an alternative. Redirecting to any other page would be wrong. So, let's delete the file and people visiting the page will see an error page showing that the page is only available for some past Symfony versions.