[Form] Better explaining what getParent actually does
#17092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main reason for changing this is to stop presenting `getParent()` of being the "default" (or normal) way of doing it. * I removed the "PHP extension" note-box, cause the (new) text for `getParent()` makes it clear what this does. * I moved `finishView()` one paragraph up (didn't change anything) * Moved all `getParent`-related stuff into its paragraph, and moved it to the top (since it's the most important question in the beginning)
carsonbot
changed the title
getParent actually doesgetParent actually does
xabbuh
approved these changes
Sep 10, 2022
|
Thank you Thomas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main reason for changing this is to stop presenting
getParent()of being the "default" (or normal) way of doing it.getParent()makes it clear what this does.finishView()one paragraph up (didn't change anything)getParent-related stuff into its paragraph, and moved it to the top (since it's the most important question in the beginning)