Skip to content

[Routing] Fix some internal references links #17061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

javiereguiluz
Copy link
Member

As you can see in this screenshot:

The list of parameters is rendered as 3 separate lists. This is because references are not supported in the middle of the list of items. So, given that the list is short, I propose to move references to the beginning of the list to fix this. Links will point to that beginning of the list, but readers can quickly see all parameters, so this could be fine.

Copy link
Contributor

@mdoutreluingne mdoutreluingne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree 👍

@javiereguiluz javiereguiluz merged commit 8db02f4 into symfony:4.4 Jul 27, 2022
@javiereguiluz javiereguiluz deleted the fix_internal_references branch July 27, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants