[Filesystem] filesystem > readlink: remove function declaration #16883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
force-pushed
the
patch-3
branch
2 times, most recently
from
92d6983 to
7c3a782
Compare
xabbuh
reviewed
Jul 13, 2022
components/filesystem.rst
Outdated
| @@ -214,9 +214,9 @@ systems (unlike PHP's :phpfunction:`readlink` function):: | |||
|
|
|||
| Its behavior is the following:: | |||
|
|
|||
| public function readlink($path, $canonicalize = false) | |||
| $filesystem->readlink($path, $canonicalize = false); | |||
There was a problem hiding this comment.
Maybe we should rather remove the whole paragraph? Even with the proposed changes I still find it rather confusing.
There was a problem hiding this comment.
I agree, there are already 2 examples of calls, this one didn't add any value, the PR has been updated.
alexislefebvre
commented
Jul 13, 2022
HeahDude
approved these changes
Jul 16, 2022
xabbuh
approved these changes
Jul 18, 2022
carsonbot
changed the title
|
Thank you Alexis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that
public functionwas confusing here: we don't want to define this method but we want to know how to use it.The code will be more consistent with the other examples.