[Component][Dependency Injection][Parent Services] - Adding compile call

[HelloGrayson]

When using the ContainerBuilder outside of Symfony2, it's not immediately obvious that $container->compile() needs to be called in order for parent services to properly resolved.

symfony/symfony#5419

[bamarni]

There is still one left under the "Overriding Parent Dependencies" section ;)

[HelloGrayson]

Good catch. Added. cc @bamarni

[richardmiller-zz]

This is still the case if you load XML or Yaml config files directly into the container builder. IMO it would be better to not have the compile call in the example at all in favour of a note that says that the containerbuilder needs to be compiled with a link back to the compilation section of the di documentation

[HelloGrayson]

I'd be open to that - the note could occur above the title "Overriding Parent Dependencies"

[HelloGrayson]

ping @weaverryan - what do you think?

[weaverryan]

@breerly sorry for the late arrival, but I agree with you guys - a nice note in here I think is the perfect solution. Can you make that change and then ping back?

Thanks!

[HelloGrayson]

Ok sounds good - I'll send an update soon.

[HelloGrayson]

ping @weaverryan @richardmiller

[richardmiller-zz]

Looks good to me

[weaverryan]

Great - merged! Thanks everyone!

[HelloGrayson]

@weaverryan this is still applicable for master/2.1 - how should I go about getting this in there as well?

[stof]

@breerly the 2.0 branch is merged into 2.1 on a regular basis (and then 2.1 into master)

[HelloGrayson]

got it thanks stof :)