Skip to content

[Runtime] Fix options path in composer.json #16807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented May 17, 2022

No description provided.

@carsonbot carsonbot added this to the 5.4 milestone May 17, 2022
@javiereguiluz
Copy link
Member

Thanks for this contribution ... but I don't understand the change 😐 You added options to the name of the option, but in the example below there is no options key, only extra and runtime.

@OskarStark
Copy link
Contributor

He removed the .options part

@OskarStark OskarStark requested a review from javiereguiluz June 6, 2022 07:49
@javiereguiluz
Copy link
Member

🤦 thanks Oskar! And sorry @l-vo. Your fix was perfect but I understood it as if it was the opposite.

This is merged now!

@javiereguiluz javiereguiluz merged commit d44e66c into symfony:5.4 Jun 6, 2022
@carsonbot carsonbot changed the title Fix options path in composer.json [Runtime] Fix options path in composer.json Jun 6, 2022
@l-vo l-vo deleted the patch-11 branch June 6, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants