Skip to content

[Runtime] Fix typo php-fpm => php-pm #16788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022
Merged

Conversation

wadjeroudi
Copy link
Contributor

No description provided.

@wouterj
Copy link
Member

wouterj commented May 6, 2022

I don't think this is a typo and "php-fpm" was meant to be used here (which is the most common way to run Symfony).

@wadjeroudi
Copy link
Contributor Author

@wouterj php-fpm doesn't need the runtime autoloader, even if it should work.
why would you use autoload_runtime on php fpm ?

From my understanding it was meant for PHP "servers" using ReactPHP technology.

Maybe @nicolas-grekas can clarify the first purpose of this component.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct :)

@javiereguiluz javiereguiluz added this to the 5.4 milestone May 6, 2022
@carsonbot carsonbot changed the title Fix typo php-fpm => php-pm [Runtime] Fix typo php-fpm => php-pm May 6, 2022
@javiereguiluz
Copy link
Member

@wadjeroudi thanks for fixing this typo ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 01b3987 into symfony:5.4 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants