[Form] [Forms] rounding default const up to down #16757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienfuchs
changed the title
|
I think we need to find another solution as the
|
|
Yes sure, can you prefer like this ? @xabbuh |
carsonbot
changed the title
javiereguiluz
force-pushed
the
fix-forms-rounding-default-const
branch
from
a2369b4 to
f7318bb
Compare
|
@sebastienfuchs thanks and congrats on your first Symfony Docs contribution 🎉 At the end I tweaked this a bit to display the two possible default values on the same line. I think it's readable enough:
|
|
Nice work 👍 Thanks @sebastienfuchs and Javier! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Just a fix about a default rounding const.
More details : https://github.com/symfony/symfony/blob/60ce5a3dfbd90fad60cd39fcb3d7bf7888a48659/src/Symfony/Component/Form/Extension/Core/Type/IntegerType.php#L49