Add caution message about reset container on each request #16750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weaverryan what do you think about this note :) ? |
|
@HeahDude what do you think about this proposal? Thanks! |
HeahDude
reviewed
Oct 5, 2022
There was a problem hiding this comment.
The caution looks legit to me, thanks for this contribution!
I've let some suggestions to reword it a bit, maybe it can inspire you @qdequippe @javiereguiluz.
Co-authored-by: Jules Pietri <heahdude@yahoo.fr>
Co-authored-by: Jules Pietri <heahdude@yahoo.fr>
Co-authored-by: Jules Pietri <heahdude@yahoo.fr>
|
Thanks @HeahDude for suggestions |
OskarStark
approved these changes
Oct 5, 2022
OskarStark
requested review from
javiereguiluz and
xabbuh
and removed request for
HeahDude
HeahDude
approved these changes
Oct 5, 2022
HeahDude
approved these changes
Oct 6, 2022
|
Thank you Quentin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to SymfonyCasts explication https://symfonycasts.com/screencast/api-platform-security/test-roles-reload :)