Skip to content

[Pull Requests] Fix Symfony upstream URL as git:// isn't supported by Github anymore. #16697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

alexandre-daubois
Copy link
Member

See: https://github.blog/2021-09-01-improving-git-protocol-security-github/
It is impossible to fetch anything now with the git:// URL.

symfony$ git fetch upstream
fatal: erreur distante : 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

@carsonbot carsonbot added this to the 4.4 milestone Apr 8, 2022
@javiereguiluz
Copy link
Member

Good catch, thanks Alexandre.

@javiereguiluz javiereguiluz merged commit 2098e0d into symfony:4.4 Apr 10, 2022
@alexislefebvre
Copy link
Contributor

Why not use git@github.com which is already used to clone the fork? (code is shown before this code)

@alexandre-daubois
Copy link
Member Author

@alexislefebvre I'd say git@github.com uses SSH. HTTPS URL doesn't, which seems more convenient.

@alexislefebvre
Copy link
Contributor

alexislefebvre commented Apr 11, 2022

git clone already uses git@github.com, so it should work at this point.

I think it would be more consistent to use git@github.com on both commands: https://symfony.com/doc/current/contributing/code/pull_requests.html#get-the-symfony-source-code

This will be equally convenient, if git@github.com works for git clone, it should work for git remote too, or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants