Adding more detail to the DI compilation page #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function load(array $configs, ContainerBuilder $container) | ||
| { | ||
| $configuration = new Configuration(); | ||
| $config = $this->processConfiguration($configuration, $configs); |
There was a problem hiding this comment.
note that this shortcut is only available in the base class proided in HttpKernel. So here, you should better write the actual code (maybe giving a tip about the method in the HttpKernel base extension)
| $loader->load('services.xml'); | ||
| } | ||
|
|
||
| //-- |
There was a problem hiding this comment.
This should be // ... (as wel as all the other // -- below). You can find these rules here: symfony.com/doc/master/contributing/documentation/overview.html#standards
weaverryan
added a commit
that referenced
this pull request
Sep 9, 2012
Adding more detail to the DI compilation page
weaverryan
added a commit
that referenced
this pull request
Sep 9, 2012
|
Hey Richard! Merged in - looks great and a lot more detail. I made very very minor tweaks as I read through. Thanks! |
weaverryan
added a commit
that referenced
this pull request
Sep 9, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the Extensions section to before the compiler pass as this makes more sense to me. Also adding more detail to the Extensions section