Skip to content

[DependencyInjection] Update service_container.rst #16596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

ahmedbouras
Copy link
Contributor

Hi ! If I'm not mistaking, we should extend the AbstractController to add a service in a controller.

Hi ! If I'm not mistaking, we should extending the AbstractController to add a service in a controller.
@carsonbot carsonbot added this to the 5.4 milestone Mar 13, 2022
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is indeed required since symfony/recipes#915

@carsonbot carsonbot changed the title Update service_container.rst [DependencyInjection] Update service_container.rst Mar 16, 2022
@javiereguiluz
Copy link
Member

Good catch Ahmed! Thanks and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 7d667bc into symfony:5.4 Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants