Skip to content

[Mailer] Update mailer.rst #16585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2022
Merged

[Mailer] Update mailer.rst #16585

merged 1 commit into from
Mar 11, 2022

Conversation

mark2016
Copy link
Contributor

Needs Annotation\Route in the use section for the route to be detected.

mdoutreluingne
mdoutreluingne approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@mdoutreluingne mdoutreluingne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

This annotation is missing for the version 4.4 and 5.4.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Mar 11, 2022
@carsonbot carsonbot changed the title Update mailer.rst [Mailer] Update mailer.rst Mar 11, 2022
@javiereguiluz javiereguiluz changed the base branch from 6.0 to 4.4 March 11, 2022 10:45
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner March 11, 2022 10:45
@javiereguiluz
Copy link
Member

Good catch, thanks @mark2016 !

@mdoutreluingne thanks for the review! We merged this in 4.4 branch and all the other upper branches.

@javiereguiluz javiereguiluz merged commit efbb654 into symfony:4.4 Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdoutreluingne mdoutreluingne mdoutreluingne approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Mailer Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mark2016 @javiereguiluz @mdoutreluingne @carsonbot