Simplify configuration env var example

[94noni]

Simplify here as the resolve is not needed, as reference it is documented in the dedicated doc page here
https://symfony.com/doc/current/configuration/env_var_processors.html

[javiereguiluz]

The resolve env var processor is used in the Symfony recipe (see https://github.com/symfony/recipes/blob/9a7f5bcebbda2f5244c4be4133a6bd181080cbea/doctrine/doctrine-bundle/2.4/config/packages/doctrine.yaml#L1-L3) so this reflects what the reader will see in their config file. Wouldn't it be better to keep it?

[94noni]

@javiereguiluz or the other way, what about removing on the recipe? it adds no value here except thinking it is required for env to be "resolved"
for me, the resolved as documented on the env var processor is enough :)

[javiereguiluz]

Yes, we can ask in the recipe server about this and see if there's a strong reason behind this. Thanks.

[nicolas-grekas]

This processor is needed when using a DSN for sqlite.

[94noni]

@nicolas-grekas thx for the answer
what about then for a simpler example remove this doctrine config and replace with another?

having the resolve here as first introduction of env var can mislead to using always the resolve as it is mandatory

[javiereguiluz]

@94noni I agree on your last proposal: let's find a simpler example that doesn't require to use resolve. Do you have something in mind? Thanks!

[94noni]

@javiereguiluz Hum what about the famous APP_SECRET ?

just a swap like:

framework:
    secret: '%env(APP_SECRET)%'

[94noni]

very unsure of those, may need careful review :s

[HeahDude]

line 509 should be kept :)
Line 507 should be changed to:
xmlns:framework="http://symfony.com/schema/dic/symfony
Finally line 510 and 511 should be changed to refer to:
http://symfony.com/schema/dic/symfony and
https://symfony.com/schema/dic/symfony/symfony-1.0.xsd

[HeahDude]

I like this move, thanks!

[HeahDude]

line 509 should be kept :)
Line 507 should be changed to:
xmlns:framework="http://symfony.com/schema/dic/symfony
Finally line 510 and 511 should be changed to refer to:
http://symfony.com/schema/dic/symfony and
https://symfony.com/schema/dic/symfony/symfony-1.0.xsd

[94noni]

@HeahDude thx for the review, I just saw them
I hope I've understood this well

[94noni]

status: needs review

[HeahDude]

Almost there :). Thanks!

[HeahDude]

You need to keep all the lines here just replacing doctrine/doctrine part by symfony/symfony:

<?xml version="1.0" encoding="UTF-8" ?>
<container xmlns="http://symfony.com/schema/dic/services"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xmlns:framework="http://symfony.com/schema/dic/symfony"
    xsi:schemaLocation="http://symfony.com/schema/dic/services
        https://symfony.com/schema/dic/services/services-1.0.xsd
        http://symfony.com/schema/dic/symfony/symfony
        https://symfony.com/schema/dic/symfony/symfony-1.0.xsd
">

[HeahDude]

Suggested change

	xmlns:framework="http://symfony.com/schema/dic/symfony
	xmlns:framework="http://symfony.com/schema/dic/symfony"

[HeahDude]

There is one extra level here (framework.secret.secret), this should be like:

$container->extension('framework', [
    'secret' => '%env(APP_SECRET)%',
]);

[nicolas-grekas]

Friendly ping @94noni

[94noni]

thx for ping, will try to handle it in Feb as I will have some "free time"
edit: as v4.4 is eol, I will close and reopen targeting v5.4, ETA in feb :)