Allowmin PHP req to change for a minor Symfony version #16543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Feb 24, 2022
|
|
||
| By exception to the rule, bumping the minimum **minor** version of PHP is | ||
| possible for a **minor** Symfony version when this helps fix important | ||
| issues. |
There was a problem hiding this comment.
Should we mention that such case would imply extending the maintenance of the previous minor version (as done for 6.0) ?
There was a problem hiding this comment.
No, I don't think this should be automatic.
fabpot
commented
Feb 24, 2022
| @@ -21,9 +21,6 @@ Before creating your first Symfony application you must: | |||
| enabled by default in most PHP 7 installations): `Ctype`_, `iconv`_, `JSON`_, | |||
| `PCRE`_, `Session`_, `SimpleXML`_, and `Tokenizer`_; | |||
|
|
|||
| * Note that all newer, released versions of PHP will be supported during the | |||
There was a problem hiding this comment.
Let's remove this as this is a duplicate of the releases docs.
|
Thanks Fabien. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify our policy about bumping the PHP minimum requirement on a Symfony minor version.