[Cache] Use path instead of url in SSI documentation
#16513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using `url` SSI tags will include the host which is likely to not work as, unlike ESI, SSI is meant to be used at the webserver level which most of the time only handles SSI as paths.
carsonbot
changed the title
path instead of url in SSI documentationpath instead of url in SSI documentation
|
Super nice catch Tug! Thanks a lot. While merging I added a minor note based on your comments (see ac13f6e) to recommend paths vs urls explicitly to avoid problems for readers. Thanks! |
|
nice addition @javiereguiluz. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
urlSSI tags will include the host which is likely to not work as, unlike ESI, SSI is meant to be used at the webserver level which most of the time only handles SSI as paths.