Skip to content

[Config] improve .env doc #16510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Conversation

houssemz
Copy link

No description provided.

@carsonbot carsonbot added this to the 4.4 milestone Feb 14, 2022
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to add - not needing to rebuild your cache is a key strength to env variables in general


Since the ``.env`` file is read and parsed on every request, you don't need to
clear the cache on ``dev`` environment nor to restart the (PHP) container in case
you are using docker.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the 2nd and 3rd lines are also indented to the same level as the word Since

And let's try this wording:

clear the Symfony cache or restart the PHP container if you're using Docker.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weaverryan OK, thank you for the review :)

@carsonbot carsonbot changed the title improve .env doc [Config] improve .env doc Mar 8, 2022
@javiereguiluz
Copy link
Member

Houssem, thanks ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit ae892ab into symfony:4.4 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants