[Testing] Removed redundancy in package requirements #16474
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
|
@fridde thanks a lot for this contribution. I need to apologize to you because I'm afraid I had some problems while merging this with the proprietary tool that we use to merge Symfony PRs ... and I accidentally removed your commit from this PR. I'm really sorry 😞 I made your changes manually in 30e02a9 Thanks! |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Mar 11, 2022
…nts (fridde) This PR was merged into the 6.0 branch. Discussion ---------- [Testing] Removed redundancy in package requirements Acoording to [symfony/testpack](https://github.com/symfony/test-pack/blob/main/composer.json) the ```phpunit/phpunit``` package is explictly included. There might be a point in showing both for clarity, but for me this redundancy created more confusion than it had explanation value. I do understand that this might be a slightly controversial PR. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 6667e41 Removed redundancy in package requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acoording to symfony/testpack the
phpunit/phpunitpackage is explictly included.There might be a point in showing both for clarity, but for me this redundancy created more confusion than it had explanation value.
I do understand that this might be a slightly controversial PR.