Skip to content

[Messenger] Correct PHP Code block for messenger resetOnMessage #16465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2022
Merged

[Messenger] Correct PHP Code block for messenger resetOnMessage #16465

merged 1 commit into from
Feb 4, 2022

Conversation

PhilETaylor
Copy link
Contributor

This PHP code was incorrect. See the yaml and the XML and compare with the PHP and you can see that (or waste 30 mins like I did debugging to work it out haha)

the method needs to be called on the MessengerConfig object and not chained after a dsn call, which will just give an undefined method error.

@carsonbot carsonbot added this to the 5.4 milestone Feb 1, 2022
@carsonbot carsonbot changed the title Correct PHP Code block for messenger resetOnMessage [Messenger] Correct PHP Code block for messenger resetOnMessage Feb 4, 2022
@javiereguiluz javiereguiluz merged commit 265edf0 into symfony:5.4 Feb 4, 2022
@javiereguiluz
Copy link
Member

Phil, we're sorry the docs were wrong and you wasted time on this 😞 Thanks for fixing it 👏

@PhilETaylor
Copy link
Contributor Author

No worries - these things happen :) At least no one else will trip over the same thing next time (that person probably be me copy and pasting again haha)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants