[Messenger] tidy MESSENGER_CONSUMER_NAME surrounds #16457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
|
Phil, thanks a lot for improving this. This was definitely error-prone and your version is much better. Thanks! |
|
No worries - I tripped over it, so others could. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am an idiot.
I have a 27" Mac so the docs renders max-width - looks like this:
When I see
due to the way the page flow of this paragraph is (see screenshot), I copy and pasted
%env(MESSENGER_CONSUMER_NAME)%)which obviously has a confusing, and not instantly spotted closing bracket.This PR simply removes the brackets in favour of commas, so that the next person doesnt waste 30 mins trying to work out why his env vars were not being replaced.
take it or leave it, if you dont think the PR has merit, or if you agree Im an idiot, then no worries, it can be closed :)