Skip to content

[Security] Move Passport Attributes to their own section #16369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

[Security] Move Passport Attributes to their own section #16369

merged 1 commit into from
Jan 5, 2022

Conversation

javiereguiluz
Copy link
Member

I think attributes are important enough to move them to their own section, which also allows them to appear in the page TOC.

@javiereguiluz javiereguiluz added this to the 5.3 milestone Jan 4, 2022
gnito-org
gnito-org approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@gnito-org gnito-org left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that attributes need a separate section.

@javiereguiluz javiereguiluz merged commit d5b6e4e into symfony:5.3 Jan 5, 2022
@javiereguiluz javiereguiluz deleted the passport_attributes branch January 5, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnito-org gnito-org gnito-org approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @gnito-org @carsonbot