Skip to content

[Testing] Minor tweaks in the main testing article #16312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

javiereguiluz
Copy link
Member

@wouterj do you know why we use .. code-block:: env instead of .. code-block:: bash for the highlighting of .env files? I don't know if env highlighting is standard or if we had to do something to support it ... but bash seems more natural and it should be standard. Thanks.

@javiereguiluz javiereguiluz added this to the 5.3 milestone Dec 22, 2021
@carsonbot carsonbot changed the title Minor tweaks in the main testing article [Testing] Minor tweaks in the main testing article Dec 22, 2021
@wouterj
Copy link
Member

wouterj commented Dec 22, 2021

env behaves just like php-symfony and all other highlighting aliases used in the Symfony docs. The highlighter is run with language bash, but for the renderer it's env. This means we can customize the label in the configuration blocks (how we use php-symfony/php-standalone), but also have different styling of the blocks.

That latter is important for env/bash: we highlight bash code blocks with a black background in the light theme (to fit the terminal frame), but we highlight env code blocks just like any other code block.

@javiereguiluz
Copy link
Member Author

Thanks for the explanation. About highlighting, please note that we changed this recently and bash blocks no longer look like terminal blocks.

@javiereguiluz javiereguiluz merged commit 11dbb4d into symfony:5.3 Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants